Switch to shared_ptr in Graph class and change Graph interface #243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
November 5, 2025 18:28
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
==========================================
- Coverage 82.36% 82.07% -0.30%
==========================================
Files 47 47
Lines 2382 2427 +45
Branches 1398 1430 +32
==========================================
+ Hits 1962 1992 +30
- Misses 194 206 +12
- Partials 226 229 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NeiroYT
changed the title
added 2 commits
December 8, 2025 20:45
allnes
reviewed
Dec 12, 2025
app/Graph/onnx_subs.cpp
Outdated
|
|
||
| int main() { | ||
| int type = 2; | ||
| Tensor aaaa = make_tensor(std::vector<int>({0})); |
allnes
reviewed
Dec 12, 2025
| } | ||
| return false; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
please remove irrelevant changes
…ev-research/itlab_2023 into neiroyt/stable_branch
aobolensk
reviewed
Dec 21, 2025
app/Graph/CMakeLists.txt
Outdated
| add_executable(ACC acc_check.cpp) | ||
| target_link_libraries(ACC BuildGraph) | ||
|
|
||
| add_executable(onnx_subs onnx_subs.cpp) |
Member
There was a problem hiding this comment.
"subs" does not really tell anything to the user. Probably, "subgraphs" would be a better name?
app/Graph/onnx_subs.cpp
Outdated
Comment on lines
52
to
66
| for (auto& i : vec) { | ||
| for (int j : i) { | ||
| std::cerr << j << ' '; | ||
| } | ||
| std::cerr << '\n'; | ||
| } | ||
| std::cerr << "Time for path5:" << time << '\n'; | ||
|
|
||
| for (auto& i : vec2) { | ||
| for (int j : i) { | ||
| std::cerr << j << ' '; | ||
| } | ||
| std::cerr << '\n'; | ||
| } | ||
| std::cerr << "Time for concat:" << time2 << '\n'; |
Member
There was a problem hiding this comment.
Please, clean up debug output
added 2 commits
December 23, 2025 18:08
aobolensk
approved these changes
Dec 23, 2025
allnes
approved these changes
Dec 23, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.